From 3d5c9a5cea13e4e9acf73a9dbd5b549a3774b0a4 Mon Sep 17 00:00:00 2001 From: Aarya Chaumal Date: Tue, 2 May 2023 23:06:56 +0530 Subject: erasure_layout.c: Fix incorrect return value in erase_write On failure of erasefn in erase_write it didn't set the error value in ret which caused send success status as return value. Change-Id: Ia3bd5fd250dcd0a03f0281c478b9bacb71872f31 Signed-off-by: Aarya Chaumal Reviewed-on: https://review.coreboot.org/c/flashrom/+/74882 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan Reviewed-by: Anastasia Klimchuk --- erasure_layout.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'erasure_layout.c') diff --git a/erasure_layout.c b/erasure_layout.c index a802ae48a..108fea4c0 100644 --- a/erasure_layout.c +++ b/erasure_layout.c @@ -328,9 +328,12 @@ int erase_write(struct flashctx *const flashctx, chipoff_t region_start, chipoff addr, addr + len - 1); free(region.name); - if (erasefn(flashctx, addr, len)) + if (erasefn(flashctx, addr, len)) { + ret = -1; goto _end; + } if (check_erased_range(flashctx, addr, len)) { + ret = - 1; msg_cerr("ERASE FAILED!\n"); goto _end; } -- cgit v1.2.3