From ccf8c6c79444108b45ed82d96b18cbdb6a8d2cff Mon Sep 17 00:00:00 2001 From: Peter Stuge Date: Fri, 23 Jan 2009 05:23:06 +0000 Subject: Check all mmap() calls and print helpful Linux error message Corresponding to flashrom svn r386 and coreboot v2 svn r3890. Signed-off-by: Peter Stuge Acked-by: Peter Stuge --- flashrom.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) (limited to 'flashrom.c') diff --git a/flashrom.c b/flashrom.c index 7e52fbc8d..26585fb72 100644 --- a/flashrom.c +++ b/flashrom.c @@ -84,6 +84,17 @@ struct pci_dev *pci_card_find(uint16_t vendor, uint16_t device, return NULL; } +void mmap_errmsg() +{ + if (EINVAL == errno) { + fprintf(stderr, "In Linux this error can be caused by the CONFIG_NONPROMISC_DEVMEM (<2.6.27),\n"); + fprintf(stderr, "CONFIG_STRICT_DEVMEM (>=2.6.27) and CONFIG_X86_PAT kernel options.\n"); + fprintf(stderr, "Please check if either is enabled in your kernel before reporting a failure.\n"); + fprintf(stderr, "You can override CONFIG_X86_PAT at boot with the nopat kernel parameter but\n"); + fprintf(stderr, "disabling the other option unfortunately requires a kernel recompile. Sorry!\n"); + } +} + int map_flash_registers(struct flashchip *flash) { volatile uint8_t *registers; @@ -94,6 +105,7 @@ int map_flash_registers(struct flashchip *flash) if (registers == MAP_FAILED) { perror("Can't mmap registers using " MEM_DEV); + mmap_errmsg(); exit(1); } flash->virtual_registers = registers; @@ -139,13 +151,7 @@ struct flashchip *probe_flash(struct flashchip *first_flash, int force) fd_mem, (off_t) base); if (bios == MAP_FAILED) { perror("Can't mmap memory using " MEM_DEV); - if (EINVAL == errno) { - fprintf(stderr, "In Linux this error can be caused by the CONFIG_NONPROMISC_DEVMEM (<2.6.27),\n"); - fprintf(stderr, "CONFIG_STRICT_DEVMEM (>=2.6.27) and CONFIG_X86_PAT kernel options.\n"); - fprintf(stderr, "Please check if either is enabled in your kernel before reporting a failure.\n"); - fprintf(stderr, "You can override CONFIG_X86_PAT at boot with the nopat kernel parameter but\n"); - fprintf(stderr, "disabling the other option unfortunately requires a kernel recompile. Sorry!\n"); - } + mmap_errmsg(); exit(1); } flash->virtual_memory = bios; -- cgit v1.2.3