From ff4c624d94d77543313b1ff8247c6430bae14bcd Mon Sep 17 00:00:00 2001 From: Werner Zeh Date: Tue, 25 Jan 2022 07:02:49 +0100 Subject: ich_descriptors.c Invert the meaning of 'dual_output' bit In the Flash Component description register (FLCOMP) bit 30 reports the capability of using dual output for fast read operation on the flash component. According to various SPI Programming Guides (checked for Panther Point, Lewisburg C620, Apollo Lake and Elkhart Lake) the dual output is enabled when this bit is set and disabled if not. Currently the logic displays it the other way around when parsing the descriptor. This patch changes this so now if bit 30 in FLCOMP is not set, dual read support for fast read operation is shown as disabled. Change-Id: If6282ac8326ab0b92e9c70c09dba0299bf0deb6f Signed-off-by: Werner Zeh Reviewed-on: https://review.coreboot.org/c/flashrom/+/61362 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- ich_descriptors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ich_descriptors.c') diff --git a/ich_descriptors.c b/ich_descriptors.c index d716d1d79..0ce572053 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -380,7 +380,7 @@ void prettyprint_ich_descriptor_component(enum ich_chipset cs, const struct ich_ pprint_freq(cs, desc->component.modes.freq_fastread)); if (cs > CHIPSET_6_SERIES_COUGAR_POINT) msg_pdbg2("Dual Output Fast Read Support: %sabled\n", - desc->component.modes.dual_output ? "dis" : "en"); + desc->component.modes.dual_output ? "en" : "dis"); int has_forbidden_opcode = 0; if (desc->component.FLILL != 0) { -- cgit v1.2.3