From 277b3fa670c548334a60c9fb5e66c2cc9e177f64 Mon Sep 17 00:00:00 2001 From: Jonathon Hall Date: Mon, 3 Oct 2022 16:12:11 -0400 Subject: ichspi: Do not attempt to map physical memory for hwseq ICH hwseq does not need to actually mmap flash, and this fails for flash chips >16 MB, since only the top 16 MB is mapped into the address space. Test: Read and write flash on ICH hwseq with 32 MB flash chip. Change-Id: Ie698071c3181e988f10b750b0e50c9700efaa1a3 Signed-off-by: Jonathon Hall Reviewed-on: https://review.coreboot.org/c/flashrom/+/68090 Reviewed-by: Edward O'Callaghan Reviewed-by: Felix Singer Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- ichspi.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'ichspi.c') diff --git a/ichspi.c b/ichspi.c index 7e7967e07..aefbe2f9d 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1794,8 +1794,6 @@ static const struct spi_master spi_master_ich9 = { }; static const struct opaque_master opaque_master_ich_hwseq = { - .map_flash_region = physmap, - .unmap_flash_region = physunmap, .max_data_read = 64, .max_data_write = 64, .probe = ich_hwseq_probe, -- cgit v1.2.3