From 8ce92004441f7a39733a5a91729584e006679829 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Mon, 11 Apr 2022 12:00:19 +0000 Subject: ichspi: Drop unused `_pprint_reg` macro This patch drops `_pprint_reg` macro as `pprint_reg` macro is now able to call into msg_pdbg(). BUG=b:223630977 TEST=Able to display HSFS register offset properly as below BIOS_CNTL = 0x8b: BIOS Lock Enable: enabled, BIOS Write Enable: enabled Warning: Setting BIOS Control at 0xdc from 0x8b to 0x89 failed. New value is 0x8b. SPIBAR = 0x00007fce5a270000 (phys = 0xfe010000) 0x04: 0xf000 (HSFS) HSFS: FDONE=0, FCERR=0, AEL=0, BERASE=0, SCIP=0, FDOPSS=1, FDV=1, FLOCKDN=1 Signed-off-by: Subrata Banik Change-Id: Iee7a23447de38423b61008b3242d28ce553ae0a2 Reviewed-on: https://review.coreboot.org/c/flashrom/+/63549 Tested-by: build bot (Jenkins) Reviewed-by: Anastasia Klimchuk Reviewed-by: Arthur Heymans --- ichspi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'ichspi.c') diff --git a/ichspi.c b/ichspi.c index 999249db4..f8936ed63 100644 --- a/ichspi.c +++ b/ichspi.c @@ -412,8 +412,7 @@ static void prettyprint_opcodes(OPCODES *ops) ops->preop[1]); } -#define _pprint_reg(bit, mask, off, val, sep) msg_pdbg("%s=%d" sep, #bit, (val & mask) >> off) -#define pprint_reg(reg, bit, val, sep) _pprint_reg(bit, reg##_##bit, reg##_##bit##_OFF, val, sep) +#define pprint_reg(reg, bit, val, sep) msg_pdbg("%s=%d" sep, #bit, (val & reg##_##bit) >> reg##_##bit##_OFF) static void prettyprint_ich9_reg_hsfs(uint16_t reg_val, enum ich_chipset ich_gen) { -- cgit v1.2.3