From a031c81f51eae94877a5076cd1a585d3cbf1bb5c Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Mon, 9 Jan 2023 10:43:47 +1100 Subject: parallel: Drop explicit fallback_chip_X boilerplate A NULL func pointer is necessary and sufficient for the condition `NULL func pointer => fallback_chip_X' as to not need this explicit specification. Therefore drop the explicit need to specify these fallback callback function pointer in the par_master struct. This is a reasonable default for every driver in the tree. Furthermore, move the 'fallback_chip_X()' func from the generic programmer.c register logic into its relevant home of parallel.c and make static local to clean up link-time symbol space. This simplifies the code and driver development. Change-Id: If25c0048a07057aa72be6ffa8d8ad7f0a568dcf7 Signed-off-by: Edward O'Callaghan Reviewed-on: https://review.coreboot.org/c/flashrom/+/71745 Reviewed-by: Stefan Reinauer Tested-by: build bot (Jenkins) --- internal.c | 1 - 1 file changed, 1 deletion(-) (limited to 'internal.c') diff --git a/internal.c b/internal.c index 9b80f3762..f21c4fcb7 100644 --- a/internal.c +++ b/internal.c @@ -116,7 +116,6 @@ static const struct par_master par_master_internal = { .chip_writeb = internal_chip_writeb, .chip_writew = internal_chip_writew, .chip_writel = internal_chip_writel, - .chip_writen = fallback_chip_writen, }; static int get_params(const struct programmer_cfg *cfg, -- cgit v1.2.3