From 3bd47524c044168b01e54e772d23c7fa723dc0d5 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Mon, 7 Jun 2021 12:33:53 +0200 Subject: treewide: Drop most cases of `sizeof(struct ...)` Spelling out the struct type name hurts readability and introduces opportunities for bugs to happen when the pointer variable type is changed but the corresponding sizeof is (are) not. TEST=`make CONFIG_EVERYTHING=yes CONFIG_JLINK_SPI=no VERSION=none -j` with and without this patch; the flashrom executable does not change. Change-Id: Icc0b60ca6ef9f5ece6ed2a0e03600bb6ccd7dcc6 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/flashrom/+/55266 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Reviewed-by: Edward O'Callaghan --- it85spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'it85spi.c') diff --git a/it85spi.c b/it85spi.c index 810f062c5..9812fc722 100644 --- a/it85spi.c +++ b/it85spi.c @@ -341,7 +341,7 @@ int it85xx_spi_init(struct superio s) (unsigned int)base); #endif - data = calloc(1, sizeof(struct it85spi_data)); + data = calloc(1, sizeof(*data)); if (!data) { msg_perr("Unable to allocate space for extra SPI master data.\n"); return SPI_GENERIC_ERROR; -- cgit v1.2.3