From 519be66fc59558971dd653afe69ccaf1a633b492 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Sun, 23 Dec 2018 20:03:35 +0100 Subject: Fix -Wsign-compare trouble Mostly by changing to `unsigned` types where applicable, sometimes `signed` types, and casting as a last resort. Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/flashrom/+/30409 Tested-by: build bot (Jenkins) Reviewed-by: Jacob Garber --- it87spi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'it87spi.c') diff --git a/it87spi.c b/it87spi.c index f8b2b0ffb..f5955fe6c 100644 --- a/it87spi.c +++ b/it87spi.c @@ -281,7 +281,6 @@ static int it8716f_spi_send_command(struct flashctx *flash, unsigned char *readarr) { uint8_t busy, writeenc; - int i; do { busy = INB(it8716f_flashport) & 0x80; @@ -330,6 +329,8 @@ static int it8716f_spi_send_command(struct flashctx *flash, | ((readcnt & 0x3) << 2) | (writeenc), it8716f_flashport); if (readcnt > 0) { + unsigned int i; + do { busy = INB(it8716f_flashport) & 0x80; } while (busy); -- cgit v1.2.3