From d4d3657b4d64b8fa38eb05ab2a50fdea3e1b45a4 Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Fri, 9 Oct 2020 13:00:17 +1100 Subject: it87spi.c: Fix layering violation of default_spi_read default_spi_read() calls spi_read_chunked() with the correct max_read value of 3 set in the spi master struct. Change-Id: I199c81e1ba501e86dbfb7cf18e2d1556e30db62e Signed-off-by: Edward O'Callaghan Reviewed-on: https://review.coreboot.org/c/flashrom/+/46233 Reviewed-by: Angel Pons Reviewed-by: Sam McNally Tested-by: build bot (Jenkins) --- it87spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'it87spi.c') diff --git a/it87spi.c b/it87spi.c index 8224db08e..e34f5e8d5 100644 --- a/it87spi.c +++ b/it87spi.c @@ -108,7 +108,7 @@ static int it8716f_spi_chip_write_256(struct flashctx *flash, const uint8_t *buf unsigned int start, unsigned int len); static const struct spi_master spi_master_it87xx = { - .max_data_read = MAX_DATA_UNSPECIFIED, + .max_data_read = 3, .max_data_write = MAX_DATA_UNSPECIFIED, .command = it8716f_spi_send_command, .multicommand = default_spi_send_multicommand, @@ -380,7 +380,7 @@ static int it8716f_spi_chip_read(struct flashctx *flash, uint8_t *buf, * via a programmer parameter for the internal programmer. */ if ((flash->chip->total_size * 1024 > 512 * 1024)) { - spi_read_chunked(flash, buf, start, len, 3); + default_spi_read(flash, buf, start, len); } else { mmio_readn((void *)(flash->virtual_memory + start), buf, len); } -- cgit v1.2.3