From 3bd47524c044168b01e54e772d23c7fa723dc0d5 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Mon, 7 Jun 2021 12:33:53 +0200 Subject: treewide: Drop most cases of `sizeof(struct ...)` Spelling out the struct type name hurts readability and introduces opportunities for bugs to happen when the pointer variable type is changed but the corresponding sizeof is (are) not. TEST=`make CONFIG_EVERYTHING=yes CONFIG_JLINK_SPI=no VERSION=none -j` with and without this patch; the flashrom executable does not change. Change-Id: Icc0b60ca6ef9f5ece6ed2a0e03600bb6ccd7dcc6 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/flashrom/+/55266 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Reviewed-by: Edward O'Callaghan --- libflashrom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libflashrom.c') diff --git a/libflashrom.c b/libflashrom.c index 09a4e4d6a..d0296d02e 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -182,7 +182,7 @@ struct flashrom_board_info *flashrom_supported_boards(void) ++boards_known_size; struct flashrom_board_info *supported_boards = - malloc(boards_known_size * sizeof(struct flashrom_board_info)); + malloc(boards_known_size * sizeof(*supported_boards)); if (supported_boards != NULL) { for (; i < boards_known_size; ++i) { -- cgit v1.2.3