From 6aaa51f19a826f18ac19ccf2acf98435d3f52ce7 Mon Sep 17 00:00:00 2001 From: Thomas Heijligen Date: Wed, 9 Jun 2021 11:50:17 +0200 Subject: libflashrom: remove flashrom_supported_programmers const char **flashrom_supported_programmers(void) returns an array of strings without returning the array size or making a NULL termination. This can lead to undefined behavior when iterating over the array. Change-Id: I0157926a654e337c14d840dd398e5576471c304f Signed-off-by: Thomas Heijligen Reviewed-on: https://review.coreboot.org/c/flashrom/+/55350 Reviewed-by: Angel Pons Reviewed-by: Nico Huber Tested-by: build bot (Jenkins) --- libflashrom.c | 20 -------------------- 1 file changed, 20 deletions(-) (limited to 'libflashrom.c') diff --git a/libflashrom.c b/libflashrom.c index 67d3ef307..d999efcd0 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -113,26 +113,6 @@ const char *flashrom_version_info(void) return flashrom_version; } -/** - * @brief Returns list of supported programmers - * @return List of supported programmers, or NULL if an error occurred - */ -const char **flashrom_supported_programmers(void) -{ - size_t p = 0; - const char **supported_programmers = malloc((programmer_table_size + 1) * sizeof(char*)); - - if (supported_programmers != NULL) { - for (; p < programmer_table_size; ++p) { - supported_programmers[p] = programmer_table[p]->name; - } - } else { - msg_gerr("Memory allocation error!\n"); - } - - return supported_programmers; -} - /** * @brief Returns list of supported flash chips * @return List of supported flash chips, or NULL if an error occurred -- cgit v1.2.3