From 3bd47524c044168b01e54e772d23c7fa723dc0d5 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Mon, 7 Jun 2021 12:33:53 +0200 Subject: treewide: Drop most cases of `sizeof(struct ...)` Spelling out the struct type name hurts readability and introduces opportunities for bugs to happen when the pointer variable type is changed but the corresponding sizeof is (are) not. TEST=`make CONFIG_EVERYTHING=yes CONFIG_JLINK_SPI=no VERSION=none -j` with and without this patch; the flashrom executable does not change. Change-Id: Icc0b60ca6ef9f5ece6ed2a0e03600bb6ccd7dcc6 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/flashrom/+/55266 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Reviewed-by: Edward O'Callaghan --- physmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'physmap.c') diff --git a/physmap.c b/physmap.c index 72d589911..6c3681461 100644 --- a/physmap.c +++ b/physmap.c @@ -292,7 +292,7 @@ static void *physmap_common(const char *descr, uintptr_t phys_addr, size_t len, } if (autocleanup) { - struct undo_physmap_data *d = malloc(sizeof(struct undo_physmap_data)); + struct undo_physmap_data *d = malloc(sizeof(*d)); if (d == NULL) { msg_perr("%s: Out of memory!\n", __func__); physunmap_unaligned(virt_addr, len); -- cgit v1.2.3