From 519be66fc59558971dd653afe69ccaf1a633b492 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Sun, 23 Dec 2018 20:03:35 +0100 Subject: Fix -Wsign-compare trouble Mostly by changing to `unsigned` types where applicable, sometimes `signed` types, and casting as a last resort. Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/flashrom/+/30409 Tested-by: build bot (Jenkins) Reviewed-by: Jacob Garber --- print_wiki.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'print_wiki.c') diff --git a/print_wiki.c b/print_wiki.c index ea8c4d73b..b2ac65c91 100644 --- a/print_wiki.c +++ b/print_wiki.c @@ -245,7 +245,7 @@ static void print_supported_boards_wiki_helper(const char *devicetype, int cols, "%d. [[#%s_ref%d|↑]]" " %s
\n", devicetype, num_notes, num_notes, devicetype, num_notes, boards[i].note); - if (ret < 0 || ret >= sizeof(tmp)) { + if (ret < 0 || (unsigned int)ret >= sizeof(tmp)) { fprintf(stderr, "Footnote text #%d of %s truncated (ret=%d, sizeof(tmp)=%zu)\n", num_notes, devicetype, ret, sizeof(tmp)); } -- cgit v1.2.3