From 2e50cdc494bf4e44c01e9e331b82a3633b1d9ef2 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Sun, 23 Sep 2018 20:20:26 +0200 Subject: Rework internal bus handling and laptop bail-out We used to bail out on any unknown laptop. However, modern systems with SPI flashes don't suffer from the original problem. Even if a flash chip is shared with the EC, the latter has to expect the host to send regular JEDEC SPI commands any time. So instead of bailing out, we limit the set of buses to probe. If we suspect to be running on a laptop, we only allow probing of SPI and opaque programmers. The user can still use the existing force options to probe all buses. This will obsolete some board-enables that could be moved to `print.c` in follow-up commits. Change-Id: I1dbda8cf0c10d7786106f14f0d18c3dcce35f0a3 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/flashrom/+/28716 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Thomas Heijligen --- programmer.h | 1 + 1 file changed, 1 insertion(+) (limited to 'programmer.h') diff --git a/programmer.h b/programmer.h index d22bc6b73..9da49f87c 100644 --- a/programmer.h +++ b/programmer.h @@ -226,6 +226,7 @@ int rpci_write_long(struct pci_dev *dev, int reg, uint32_t data); struct penable { uint16_t vendor_id; uint16_t device_id; + enum chipbustype buses; const enum test_state status; const char *vendor_name; const char *device_name; -- cgit v1.2.3