From 6c8bd91e29719b9db2198d6ebf1ea33a26f9f5aa Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Wed, 25 Mar 2020 13:35:45 +0100 Subject: Fix segfault when running `flashrom -L` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The raiden_debug programmer is of type USB. However, it does not set the field `devs.dev`, which will result in a segfault when trying to print the devices of the non-existing table. Fix that by replacing `devs.note` with `devs.dev` and adding an empty device table. Since Device IDs are not used to match programmers, nothing could be added to the table. TEST=Running `flashrom -L` no longer segfaults and returns normally. Change-Id: Ie4171a11384c34abb102d1aadf86aa1b8829fc04 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/flashrom/+/39826 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Paul Menzel --- programmer.h | 1 + 1 file changed, 1 insertion(+) (limited to 'programmer.h') diff --git a/programmer.h b/programmer.h index 08500c6fc..9a41be107 100644 --- a/programmer.h +++ b/programmer.h @@ -407,6 +407,7 @@ extern const struct dev_entry gfx_nvidia[]; /* raiden_debug_spi.c */ #if CONFIG_RAIDEN == 1 int raiden_debug_spi_init(void); +extern const struct dev_entry devs_raiden[]; #endif /* drkaiser.c */ -- cgit v1.2.3