From 541f79df447dba7f91a6101766c6b44aaf751075 Mon Sep 17 00:00:00 2001 From: Peter Marheine Date: Wed, 4 Aug 2021 17:13:42 +1000 Subject: realtek_mst_i2c_spi: don't always fail init In some earlier refactoring the init function for this programmer was broken such that it never succeeds, since the return value was never set to a value other than a generic failure. Fix it to return success unless there is a problem. TEST=flashrom -p realtek_mst_i2c_spi:bus=n --flash-size now works when n is a bus that has a connected MST. Change-Id: I0596014fc9b76b4d11de230f9f5c414c1321dff1 Signed-off-by: Peter Marheine Reviewed-on: https://review.coreboot.org/c/flashrom/+/56799 Reviewed-by: Edward O'Callaghan Reviewed-by: Anastasia Klimchuk Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- realtek_mst_i2c_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'realtek_mst_i2c_spi.c') diff --git a/realtek_mst_i2c_spi.c b/realtek_mst_i2c_spi.c index 22f7e7afd..a45838cb6 100644 --- a/realtek_mst_i2c_spi.c +++ b/realtek_mst_i2c_spi.c @@ -445,7 +445,7 @@ static int realtek_mst_i2c_spi_shutdown(void *data) static int get_params(int *reset, int *enter_isp) { char *reset_str = NULL, *isp_str = NULL; - int ret = SPI_GENERIC_ERROR; + int ret = 0; reset_str = extract_programmer_param("reset-mcu"); if (reset_str) { -- cgit v1.2.3