From 01624f40eeec33c546150a240f194f057f6dd36e Mon Sep 17 00:00:00 2001 From: Carl-Daniel Hailfinger Date: Tue, 12 May 2009 15:38:55 +0000 Subject: Use helper functions chip_{read,write}[bwl] to access flash chips The semantic patch I used in r418 to make the original conversion to accessor functions was missing one isomorphism: a[b] <=> *(a+b) The semantic patcher Coccinelle was used to create this patch. Semantic patch follows: @@ typedef uint8_t; expression a; volatile uint8_t *b; @@ - b[a] + *(b + a) @@ expression a; volatile uint8_t *b; @@ - *(b) = (a); + chip_writeb(a, b); @@ volatile uint8_t *b; @@ - *(b) + chip_readb(b) @@ type T; T b; @@ ( chip_readb | chip_writeb ) (..., - (T) - (b) + b ) Corresponding to flashrom svn r498. Signed-off-by: Carl-Daniel Hailfinger Acked-by: Uwe Hermann --- w39v080fa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'w39v080fa.c') diff --git a/w39v080fa.c b/w39v080fa.c index ba32add9f..7b827f82d 100644 --- a/w39v080fa.c +++ b/w39v080fa.c @@ -180,8 +180,8 @@ int erase_winbond_fwhub(struct flashchip *flash) printf("\n"); for (i = 0; i < total_size; i++) { - if (bios[i] != 0xff) { - fprintf(stderr, "Error: Flash chip erase failed at 0x%08x(0x%02x)\n", i, bios[i]); + if (chip_readb(bios + i) != 0xff) { + fprintf(stderr, "Error: Flash chip erase failed at 0x%08x(0x%02x)\n", i, chip_readb(bios + i)); return -1; } } -- cgit v1.2.3