summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLi Zefan <lizf@cn.fujitsu.com>2007-11-28 09:56:27 +0100
committerGreg Kroah-Hartman <gregkh@suse.de>2007-12-14 09:51:02 -0800
commit1aa640f72f0275f30cba9ed8456e07824dd730ad (patch)
treebd15eb546c278b748f2f6c7154798c520d880995
parent79aa197996fd187b0935e6c3369e8f73edf2cd9f (diff)
downloadlinux-stable-1aa640f72f0275f30cba9ed8456e07824dd730ad.tar.gz
linux-stable-1aa640f72f0275f30cba9ed8456e07824dd730ad.tar.bz2
linux-stable-1aa640f72f0275f30cba9ed8456e07824dd730ad.zip
nf_nat: fix memset error
This patch fixes an incorrect memset in the NAT code, causing misbehaviour when unloading and reloading the NAT module. Applies to stable-2.6.22 and stable-2.6.23. Please apply, thanks. [NETFILTER]: nf_nat: fix memset error Upstream commit e0bf9cf15fc30d300b7fbd821c6bc975531fab44 The size passing to memset is the size of a pointer. Fixes misbehaviour when unloading and reloading the NAT module. Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--net/ipv4/netfilter/nf_nat_core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/netfilter/nf_nat_core.c b/net/ipv4/netfilter/nf_nat_core.c
index deab27facbad..553ebb8ff76f 100644
--- a/net/ipv4/netfilter/nf_nat_core.c
+++ b/net/ipv4/netfilter/nf_nat_core.c
@@ -681,7 +681,7 @@ static int clean_nat(struct nf_conn *i, void *data)
if (!nat)
return 0;
- memset(nat, 0, sizeof(nat));
+ memset(nat, 0, sizeof(*nat));
i->status &= ~(IPS_NAT_MASK | IPS_NAT_DONE_MASK | IPS_SEQ_ADJUST);
return 0;
}