diff options
| author | Eric Sandeen <sandeen@redhat.com> | 2012-11-14 22:22:05 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-01-21 11:44:59 -0800 |
| commit | 97765f30c49d3023a6dafe7c48c7e520fca441f8 (patch) | |
| tree | 857afd3c92912cf780860597d87436b38c5902e7 | |
| parent | a6d8f58e7c32624663e6f41ecd2c94c487fffcb0 (diff) | |
| download | linux-stable-97765f30c49d3023a6dafe7c48c7e520fca441f8.tar.gz linux-stable-97765f30c49d3023a6dafe7c48c7e520fca441f8.tar.bz2 linux-stable-97765f30c49d3023a6dafe7c48c7e520fca441f8.zip | |
ext4: init pagevec in ext4_da_block_invalidatepages
commit 66bea92c69477a75a5d37b9bfed5773c92a3c4b4 upstream.
ext4_da_block_invalidatepages is missing a pagevec_init(),
which means that pvec->cold contains random garbage.
This affects whether the page goes to the front or
back of the LRU when ->cold makes it to
free_hot_cold_page()
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: CAI Qian <caiqian@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/ext4/inode.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 1dbf758c4964..7e56946a5199 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -2199,6 +2199,8 @@ static void ext4_da_block_invalidatepages(struct mpage_da_data *mpd) index = mpd->first_page; end = mpd->next_page - 1; + + pagevec_init(&pvec, 0); while (index <= end) { nr_pages = pagevec_lookup(&pvec, mapping, index, PAGEVEC_SIZE); if (nr_pages == 0) |