diff options
| author | Ma Ke <make24@iscas.ac.cn> | 2024-09-05 10:09:17 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-10-22 15:56:50 +0200 |
| commit | 0a4d4dbef622ac8796a6665e0080da2685f9220a (patch) | |
| tree | 277cdf2899b7f2efe81227ee8706c7c03e0faa3e | |
| parent | 4a81800ef05bea5a9896f199677f7b7f5020776a (diff) | |
| download | linux-stable-0a4d4dbef622ac8796a6665e0080da2685f9220a.tar.gz linux-stable-0a4d4dbef622ac8796a6665e0080da2685f9220a.tar.bz2 linux-stable-0a4d4dbef622ac8796a6665e0080da2685f9220a.zip | |
pinctrl: apple: check devm_kasprintf() returned value
commit 665a58fe663ac7a9ea618dc0b29881649324b116 upstream.
devm_kasprintf() can return a NULL pointer on failure but this returned
value is not checked. Fix this lack and check the returned value.
Found by code review.
Cc: stable@vger.kernel.org
Fixes: a0f160ffcb83 ("pinctrl: add pinctrl/GPIO driver for Apple SoCs")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/20240905020917.356534-1-make24@iscas.ac.cn
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/pinctrl/pinctrl-apple-gpio.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/pinctrl/pinctrl-apple-gpio.c b/drivers/pinctrl/pinctrl-apple-gpio.c index 2490384ef1b8..b6b309b26986 100644 --- a/drivers/pinctrl/pinctrl-apple-gpio.c +++ b/drivers/pinctrl/pinctrl-apple-gpio.c @@ -471,6 +471,9 @@ static int apple_gpio_pinctrl_probe(struct platform_device *pdev) for (i = 0; i < npins; i++) { pins[i].number = i; pins[i].name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "PIN%u", i); + if (!pins[i].name) + return -ENOMEM; + pins[i].drv_data = pctl; pin_names[i] = pins[i].name; pin_nums[i] = i; |