summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2022-05-04 07:29:49 -0700
committerJens Axboe <axboe@kernel.dk>2022-05-04 18:29:52 -0600
commit513616843d736fb7161b4460cdfe5aa825c5902c (patch)
tree8081ebe033df5237f6f4d59dd4d835605c9fd18c
parentf624506f98b198e65b44da303f44974590fb16c0 (diff)
downloadlinux-stable-513616843d736fb7161b4460cdfe5aa825c5902c.tar.gz
linux-stable-513616843d736fb7161b4460cdfe5aa825c5902c.tar.bz2
linux-stable-513616843d736fb7161b4460cdfe5aa825c5902c.zip
block: remove superfluous calls to blkcg_bio_issue_init
blkcg_bio_issue_init is called in submit_bio. There is no need to have extra calls that just get overriden in __bio_clone and the two places that copy and pasted from it. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Mike Snitzer <snitzer@kernel.org> Link: https://lore.kernel.org/r/20220504142950.567582-2-hch@lst.de Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r--block/bio.c1
-rw-r--r--block/blk-crypto-fallback.c1
-rw-r--r--block/bounce.c1
3 files changed, 0 insertions, 3 deletions
diff --git a/block/bio.c b/block/bio.c
index 212ccd5b5212..aa94195ffd02 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -768,7 +768,6 @@ static int __bio_clone(struct bio *bio, struct bio *bio_src, gfp_t gfp)
bio->bi_iter = bio_src->bi_iter;
bio_clone_blkg_association(bio, bio_src);
- blkcg_bio_issue_init(bio);
if (bio_crypt_clone(bio, bio_src, gfp) < 0)
return -ENOMEM;
diff --git a/block/blk-crypto-fallback.c b/block/blk-crypto-fallback.c
index 5d1aa5b1d30a..621abd1b0e4d 100644
--- a/block/blk-crypto-fallback.c
+++ b/block/blk-crypto-fallback.c
@@ -179,7 +179,6 @@ static struct bio *blk_crypto_fallback_clone_bio(struct bio *bio_src)
bio->bi_io_vec[bio->bi_vcnt++] = bv;
bio_clone_blkg_association(bio, bio_src);
- blkcg_bio_issue_init(bio);
return bio;
}
diff --git a/block/bounce.c b/block/bounce.c
index 467be46d0e65..8f7b6fe3b4db 100644
--- a/block/bounce.c
+++ b/block/bounce.c
@@ -191,7 +191,6 @@ static struct bio *bounce_clone_bio(struct bio *bio_src)
goto err_put;
bio_clone_blkg_association(bio, bio_src);
- blkcg_bio_issue_init(bio);
return bio;