diff options
| author | Sven Eckelmann <sven@narfation.org> | 2015-06-21 14:42:49 +0200 |
|---|---|---|
| committer | Antonio Quartulli <antonio@meshcoding.com> | 2015-08-25 00:12:21 +0200 |
| commit | 77927b7d9dd6c9c5f59f0f49c76cda54b908090e (patch) | |
| tree | 15a4c680aeecebfeea3517da29b2dc764f28ce81 | |
| parent | a121048a89f8186fa2c8388d5b41528466013857 (diff) | |
| download | linux-stable-77927b7d9dd6c9c5f59f0f49c76cda54b908090e.tar.gz linux-stable-77927b7d9dd6c9c5f59f0f49c76cda54b908090e.tar.bz2 linux-stable-77927b7d9dd6c9c5f59f0f49c76cda54b908090e.zip | |
batman-adv: Return EINVAL on invalid gw_bandwidth change
Invalid speed settings by the user are currently acknowledged as correct
but not stored. Instead the return of the store operation of the file
"gw_bandwidth" should indicate that the given value is not acceptable.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
| -rw-r--r-- | net/batman-adv/gateway_common.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/batman-adv/gateway_common.c b/net/batman-adv/gateway_common.c index c50931cbfbb5..6b930a651f38 100644 --- a/net/batman-adv/gateway_common.c +++ b/net/batman-adv/gateway_common.c @@ -19,6 +19,7 @@ #include "main.h" #include <linux/atomic.h> +#include <linux/errno.h> #include <linux/byteorder/generic.h> #include <linux/kernel.h> #include <linux/netdevice.h> @@ -160,7 +161,7 @@ ssize_t batadv_gw_bandwidth_set(struct net_device *net_dev, char *buff, ret = batadv_parse_gw_bandwidth(net_dev, buff, &down_new, &up_new); if (!ret) - goto end; + return -EINVAL; if (!down_new) down_new = 1; @@ -184,7 +185,6 @@ ssize_t batadv_gw_bandwidth_set(struct net_device *net_dev, char *buff, atomic_set(&bat_priv->gw.bandwidth_up, up_new); batadv_gw_tvlv_container_update(bat_priv); -end: return count; } |