diff options
| author | Artem Chernyshev <artem.chernyshev@red-soft.ru> | 2022-12-01 17:00:30 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-12-14 11:37:24 +0100 |
| commit | a4c342e645d6bc7d947d682fcfd4fc245ecf99e5 (patch) | |
| tree | 5eca2732b6d06fb9f7459018124be75eb489d2da | |
| parent | edf7284a98296369dd0891a0457eec37df244873 (diff) | |
| download | linux-stable-a4c342e645d6bc7d947d682fcfd4fc245ecf99e5.tar.gz linux-stable-a4c342e645d6bc7d947d682fcfd4fc245ecf99e5.tar.bz2 linux-stable-a4c342e645d6bc7d947d682fcfd4fc245ecf99e5.zip | |
net: dsa: ksz: Check return value
[ Upstream commit 3d8fdcbf1f42e2bb9ae8b8c0b6f202278c788a22 ]
Return NULL if we got unexpected value from skb_trim_rcsum()
in ksz_common_rcv()
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: bafe9ba7d908 ("net: dsa: ksz: Factor out common tag code")
Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20221201140032.26746-1-artem.chernyshev@red-soft.ru
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | net/dsa/tag_ksz.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/dsa/tag_ksz.c b/net/dsa/tag_ksz.c index fa1d60d13ad9..6795dd017499 100644 --- a/net/dsa/tag_ksz.c +++ b/net/dsa/tag_ksz.c @@ -22,7 +22,8 @@ static struct sk_buff *ksz_common_rcv(struct sk_buff *skb, if (!skb->dev) return NULL; - pskb_trim_rcsum(skb, skb->len - len); + if (pskb_trim_rcsum(skb, skb->len - len)) + return NULL; dsa_default_offload_fwd_mark(skb); |