summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZhengchao Shao <shaozhengchao@huawei.com>2022-12-02 01:38:49 -0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-12-02 17:48:04 +0100
commitd7237462561fcd224fa687c56ccb68629f50fc0d (patch)
tree160f71ecb3e313b7f80925e2b762e592c3378508
parentbbb09f8353c1192ce436eb32ffae9105bc6e1d27 (diff)
downloadlinux-stable-d7237462561fcd224fa687c56ccb68629f50fc0d.tar.gz
linux-stable-d7237462561fcd224fa687c56ccb68629f50fc0d.tar.bz2
linux-stable-d7237462561fcd224fa687c56ccb68629f50fc0d.zip
drivers: mcb: fix resource leak in mcb_probe()
When probe hook function failed in mcb_probe(), it doesn't put the device. Compiled test only. Fixes: 7bc364097a89 ("mcb: Acquire reference to device in probe") Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> Signed-off-by: Johannes Thumshirn <jth@kernel.org> Link: https://lore.kernel.org/r/9f87de36bfb85158b506cb78c6fc9db3f6a3bad1.1669624063.git.johannes.thumshirn@wdc.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/mcb/mcb-core.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/mcb/mcb-core.c b/drivers/mcb/mcb-core.c
index 338fc889b357..b8ad4f16b4ac 100644
--- a/drivers/mcb/mcb-core.c
+++ b/drivers/mcb/mcb-core.c
@@ -71,8 +71,10 @@ static int mcb_probe(struct device *dev)
get_device(dev);
ret = mdrv->probe(mdev, found_id);
- if (ret)
+ if (ret) {
module_put(carrier_mod);
+ put_device(dev);
+ }
return ret;
}