diff options
| author | Jens Axboe <axboe@kernel.dk> | 2018-08-14 10:52:40 -0600 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-09-15 09:46:49 +0200 |
| commit | b02fd8a8dc25e237b2f8b78ff662c6b4d6995598 (patch) | |
| tree | 3e94a7ca854476952deb04b5dd89139a257a16db /block | |
| parent | 534dde34bb7dfe47e030a0a1cb0e2d17c0c4bac3 (diff) | |
| download | linux-stable-b02fd8a8dc25e237b2f8b78ff662c6b4d6995598.tar.gz linux-stable-b02fd8a8dc25e237b2f8b78ff662c6b4d6995598.tar.bz2 linux-stable-b02fd8a8dc25e237b2f8b78ff662c6b4d6995598.zip | |
block: don't warn for flush on read-only device
[ Upstream commit b089cfd95d32638335c551651a8e00fd2c4edb0b ]
Don't warn for a flush issued to a read-only device. It's not strictly
a writable command, as it doesn't change any on-media data by itself.
Reported-by: Stefan Agner <stefan@agner.ch>
Fixes: 721c7fc701c7 ("block: fail op_is_write() requests to read-only partitions")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'block')
| -rw-r--r-- | block/blk-core.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/block/blk-core.c b/block/blk-core.c index 1646ea85dade..746a5eac4541 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -2159,7 +2159,9 @@ static inline bool should_fail_request(struct hd_struct *part, static inline bool bio_check_ro(struct bio *bio, struct hd_struct *part) { - if (part->policy && op_is_write(bio_op(bio))) { + const int op = bio_op(bio); + + if (part->policy && (op_is_write(op) && !op_is_flush(op))) { char b[BDEVNAME_SIZE]; WARN_ONCE(1, |