diff options
| author | Junlin Yang <yangjunlin@yulong.com> | 2021-02-15 18:36:43 +0800 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2021-03-10 14:41:12 +0100 |
| commit | ffeaa23aa001b46b5fb35cb5e3f5ddb796d9b462 (patch) | |
| tree | 6d273120402e46fb6e8b4e26191e2e29bf26662d /drivers/pinctrl/stm32 | |
| parent | a7db796b305bba7b4fd78eac2c50647a7cafe0f7 (diff) | |
| download | linux-stable-ffeaa23aa001b46b5fb35cb5e3f5ddb796d9b462.tar.gz linux-stable-ffeaa23aa001b46b5fb35cb5e3f5ddb796d9b462.tar.bz2 linux-stable-ffeaa23aa001b46b5fb35cb5e3f5ddb796d9b462.zip | |
pinctrl: stm32: add missing of_node_put
Fix OF node leaks by calling of_node_put in
for_each_available_child_of_node when the cycle returns.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
Link: https://lore.kernel.org/r/20210215103643.898-1-angkery@163.com
Acked-by: Fabien Dessenne <fabien.dessenne@foss.st.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/stm32')
| -rw-r--r-- | drivers/pinctrl/stm32/pinctrl-stm32.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c index 7d9bdedcd71b..da72e3e5c08d 100644 --- a/drivers/pinctrl/stm32/pinctrl-stm32.c +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c @@ -1542,8 +1542,10 @@ int stm32_pctl_probe(struct platform_device *pdev) if (of_property_read_bool(child, "gpio-controller")) { bank->rstc = of_reset_control_get_exclusive(child, NULL); - if (PTR_ERR(bank->rstc) == -EPROBE_DEFER) + if (PTR_ERR(bank->rstc) == -EPROBE_DEFER) { + of_node_put(child); return -EPROBE_DEFER; + } bank->clk = of_clk_get_by_name(child, NULL); if (IS_ERR(bank->clk)) { @@ -1551,6 +1553,7 @@ int stm32_pctl_probe(struct platform_device *pdev) dev_err(dev, "failed to get clk (%ld)\n", PTR_ERR(bank->clk)); + of_node_put(child); return PTR_ERR(bank->clk); } i++; |