summaryrefslogtreecommitdiffstats
path: root/drivers/tty
diff options
context:
space:
mode:
authorDaniel Starke <daniel.starke@siemens.com>2023-08-17 11:32:27 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-08-22 15:21:24 +0200
commitb99f51ba04035b2394cae008f9ac09563b012307 (patch)
treedafcbe3fa9c977257d39edcc00c7b1ce0e5dfd5d /drivers/tty
parenta1ce6da0833b91355499568caf0f432074d91cee (diff)
downloadlinux-stable-b99f51ba04035b2394cae008f9ac09563b012307.tar.gz
linux-stable-b99f51ba04035b2394cae008f9ac09563b012307.tar.bz2
linux-stable-b99f51ba04035b2394cae008f9ac09563b012307.zip
tty: n_gsm: increase malformed counter for malformed control frames
The malformed counter in gsm_mux is already increased in case of errors detected in gsm_queue() and gsm1_receive(). gsm_dlci_command() also detects a case for a malformed frame but does not increase the malformed counter yet. Fix this by also increasing the gsm_mux malformed counter in case of a malformed frame in gsm_dlci_command(). Note that the malformed counter is not yet exposed and only set internally. Signed-off-by: Daniel Starke <daniel.starke@siemens.com> Link: https://lore.kernel.org/r/20230817093231.2317-5-daniel.starke@siemens.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
-rw-r--r--drivers/tty/n_gsm.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 68276a7e62a0..2dc5bf14da2d 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -2455,8 +2455,10 @@ static void gsm_dlci_command(struct gsm_dlci *dlci, const u8 *data, int len)
data += dlen;
/* Malformed command? */
- if (clen > len)
+ if (clen > len) {
+ dlci->gsm->malformed++;
return;
+ }
if (command & 1)
gsm_control_message(dlci->gsm, command, data, clen);