diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2020-12-12 19:20:05 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-12-30 11:51:27 +0100 |
| commit | 226bcdbb4a60ed676e038d1511c758dda8e3667b (patch) | |
| tree | 01156e1a6507a6f06e942b6cf820608e22c5d892 /drivers | |
| parent | efc570073cbe2620e1564d9c6246381518298ab2 (diff) | |
| download | linux-stable-226bcdbb4a60ed676e038d1511c758dda8e3667b.tar.gz linux-stable-226bcdbb4a60ed676e038d1511c758dda8e3667b.tar.bz2 linux-stable-226bcdbb4a60ed676e038d1511c758dda8e3667b.zip | |
net: bcmgenet: Fix a resource leak in an error handling path in the probe functin
[ Upstream commit 4375ada01963d1ebf733d60d1bb6e5db401e1ac6 ]
If the 'register_netdev()' call fails, we must undo a previous
'bcmgenet_mii_init()' call.
Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20201212182005.120437-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 03f82786c0b9..b27da024aa9d 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3584,8 +3584,10 @@ static int bcmgenet_probe(struct platform_device *pdev) clk_disable_unprepare(priv->clk); err = register_netdev(dev); - if (err) + if (err) { + bcmgenet_mii_exit(dev); goto err; + } return err; |