diff options
| author | Darrick J. Wong <darrick.wong@oracle.com> | 2019-03-23 12:10:29 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-04-20 09:15:03 +0200 |
| commit | 6fee657dfd593ad45c762fa2613c0c14406188ba (patch) | |
| tree | 5d16b8ad0b461fe549671d83b854ef93898b87a0 /fs | |
| parent | 329f34e8cddf66b21e3ad0082fcb410fdc5e61ac (diff) | |
| download | linux-stable-6fee657dfd593ad45c762fa2613c0c14406188ba.tar.gz linux-stable-6fee657dfd593ad45c762fa2613c0c14406188ba.tar.bz2 linux-stable-6fee657dfd593ad45c762fa2613c0c14406188ba.zip | |
ext4: prohibit fstrim in norecovery mode
[ Upstream commit 18915b5873f07e5030e6fb108a050fa7c71c59fb ]
The ext4 fstrim implementation uses the block bitmaps to find free space
that can be discarded. If we haven't replayed the journal, the bitmaps
will be stale and we absolutely *cannot* use stale metadata to zap the
underlying storage.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/ext4/ioctl.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index 7917cc89ab21..3dbf4e414706 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -940,6 +940,13 @@ resizefs_out: if (!blk_queue_discard(q)) return -EOPNOTSUPP; + /* + * We haven't replayed the journal, so we cannot use our + * block-bitmap-guided storage zapping commands. + */ + if (test_opt(sb, NOLOAD) && ext4_has_feature_journal(sb)) + return -EROFS; + if (copy_from_user(&range, (struct fstrim_range __user *)arg, sizeof(range))) return -EFAULT; |