diff options
author | Eric Dumazet <eric.dumazet@gmail.com> | 2011-01-25 19:40:51 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-02-17 15:14:46 -0800 |
commit | 785fb57c98233ad3d9818259c3c139585cfbff3e (patch) | |
tree | 4b44990b53e89b1b5bce14ffaae35d16ef8ea660 /kernel/perf_event.c | |
parent | e7e78456b4aa3c087129b9dec0ad90b1cedec57f (diff) | |
download | linux-stable-785fb57c98233ad3d9818259c3c139585cfbff3e.tar.gz linux-stable-785fb57c98233ad3d9818259c3c139585cfbff3e.tar.bz2 linux-stable-785fb57c98233ad3d9818259c3c139585cfbff3e.zip |
perf: Fix alloc_callchain_buffers()
commit 88d4f0db7fa8785859c1d637f9aac210932b6216 upstream.
Commit 927c7a9e92c4 ("perf: Fix race in callchains") introduced
a mismatch in the sizing of struct callchain_cpus_entries.
nr_cpu_ids must be used instead of num_possible_cpus(), or we
might get out of bound memory accesses on some machines.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: David Miller <davem@davemloft.net>
Cc: Stephane Eranian <eranian@google.com>
LKML-Reference: <1295980851.3588.351.camel@edumazet-laptop>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'kernel/perf_event.c')
-rw-r--r-- | kernel/perf_event.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/kernel/perf_event.c b/kernel/perf_event.c index 2870feee81dd..8465baf40087 100644 --- a/kernel/perf_event.c +++ b/kernel/perf_event.c @@ -1872,8 +1872,7 @@ static int alloc_callchain_buffers(void) * accessed from NMI. Use a temporary manual per cpu allocation * until that gets sorted out. */ - size = sizeof(*entries) + sizeof(struct perf_callchain_entry *) * - num_possible_cpus(); + size = offsetof(struct callchain_cpus_entries, cpu_entries[nr_cpu_ids]); entries = kzalloc(size, GFP_KERNEL); if (!entries) |