diff options
author | Biwen Li <biwen.li@nxp.com> | 2019-08-29 10:14:18 +0800 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-10-07 18:59:31 +0200 |
commit | 30f8969d6265891d30ef0b2ee236020932e3b20d (patch) | |
tree | c0b7d07ce754d46c13fa61f5e5755739b17f023f /kernel/sched/deadline.c | |
parent | 1a5f22226ad004e670048b073a935be76b711a49 (diff) | |
download | linux-stable-30f8969d6265891d30ef0b2ee236020932e3b20d.tar.gz linux-stable-30f8969d6265891d30ef0b2ee236020932e3b20d.tar.bz2 linux-stable-30f8969d6265891d30ef0b2ee236020932e3b20d.zip |
rtc: pcf85363/pcf85263: fix regmap error in set_time
[ Upstream commit 7ef66122bdb3b839e9f51b76d7e600b6e21ef648 ]
Issue:
- # hwclock -w
hwclock: RTC_SET_TIME: Invalid argument
Why:
- Relative commit: 8b9f9d4dc511 ("regmap: verify if register is
writeable before writing operations"), this patch
will always check for unwritable registers, it will compare reg
with max_register in regmap_writeable.
- The pcf85363/pcf85263 has the capability of address wrapping
which means if you access an address outside the allowed range
(0x00-0x2f) hardware actually wraps the access to a lower address.
The rtc-pcf85363 driver will use this feature to configure the time
and execute 2 actions in the same i2c write operation (stopping the
clock and configure the time). However the driver has also
configured the `regmap maxregister` protection mechanism that will
block accessing addresses outside valid range (0x00-0x2f).
How:
- Split of writing regs to two parts, first part writes control
registers about stop_enable and resets, second part writes
RTC time and date registers.
Signed-off-by: Biwen Li <biwen.li@nxp.com>
Link: https://lore.kernel.org/r/20190829021418.4607-1-biwen.li@nxp.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'kernel/sched/deadline.c')
0 files changed, 0 insertions, 0 deletions