summaryrefslogtreecommitdiffstats
path: root/net/mptcp
diff options
context:
space:
mode:
authorGeliang Tang <geliang.tang@suse.com>2022-03-07 12:44:39 -0800
committerJakub Kicinski <kuba@kernel.org>2022-03-08 22:06:12 -0800
commit0dc626e5e853a966dfbb6ee6cd607e13a2acd5ae (patch)
treeeb14f91635bc38a1f4ec50ea5e02ad569178654d /net/mptcp
parent69c6ce7b6ecad8ed6c1b785bfadf50159d9f1023 (diff)
downloadlinux-stable-0dc626e5e853a966dfbb6ee6cd607e13a2acd5ae.tar.gz
linux-stable-0dc626e5e853a966dfbb6ee6cd607e13a2acd5ae.tar.bz2
linux-stable-0dc626e5e853a966dfbb6ee6cd607e13a2acd5ae.zip
mptcp: add fullmesh flag check for adding address
The fullmesh flag mustn't be used with the signal flag when adding an address. This patch added the necessary flags check for this case. Fixes: 73c762c1f07d ("mptcp: set fullmesh flag in pm_netlink") Signed-off-by: Geliang Tang <geliang.tang@suse.com> Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/mptcp')
-rw-r--r--net/mptcp/pm_netlink.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index e090810bb35d..800515fe5e1d 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm_netlink.c
@@ -1264,6 +1264,12 @@ static int mptcp_nl_cmd_add_addr(struct sk_buff *skb, struct genl_info *info)
return -EINVAL;
}
+ if (addr.flags & MPTCP_PM_ADDR_FLAG_SIGNAL &&
+ addr.flags & MPTCP_PM_ADDR_FLAG_FULLMESH) {
+ GENL_SET_ERR_MSG(info, "flags mustn't have both signal and fullmesh");
+ return -EINVAL;
+ }
+
if (addr.flags & MPTCP_PM_ADDR_FLAG_IMPLICIT) {
GENL_SET_ERR_MSG(info, "can't create IMPLICIT endpoint");
return -EINVAL;