summaryrefslogtreecommitdiffstats
path: root/net/smc/smc_cdc.c
diff options
context:
space:
mode:
authorKarsten Graul <kgraul@linux.ibm.com>2020-05-30 16:42:37 +0200
committerDavid S. Miller <davem@davemloft.net>2020-05-30 18:12:25 -0700
commitb8ded9de8db34dd209a3dece94cf54fc414e78f7 (patch)
tree3dbc406c8c0caec84fbc5763491d86ea13a9a20f /net/smc/smc_cdc.c
parentb86a372201153326bad2c7048aef1bd7accbcbbc (diff)
downloadlinux-stable-b8ded9de8db34dd209a3dece94cf54fc414e78f7.tar.gz
linux-stable-b8ded9de8db34dd209a3dece94cf54fc414e78f7.tar.bz2
linux-stable-b8ded9de8db34dd209a3dece94cf54fc414e78f7.zip
net/smc: pre-fetch send buffer outside of send_lock
Pre-fetch send buffer for the CDC validation message before entering the send_lock. Without that the send call might fail with -EBUSY because there are no free buffers and waiting for buffers is not possible under send_lock. Signed-off-by: Karsten Graul <kgraul@linux.ibm.com> Reviewed-by: Ursula Braun <ubraun@linux.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/smc/smc_cdc.c')
-rw-r--r--net/smc/smc_cdc.c10
1 files changed, 3 insertions, 7 deletions
diff --git a/net/smc/smc_cdc.c b/net/smc/smc_cdc.c
index b2b85e1be72c..a47e8855e045 100644
--- a/net/smc/smc_cdc.c
+++ b/net/smc/smc_cdc.c
@@ -116,19 +116,15 @@ int smc_cdc_msg_send(struct smc_connection *conn,
}
/* send a validation msg indicating the move of a conn to an other QP link */
-int smcr_cdc_msg_send_validation(struct smc_connection *conn)
+int smcr_cdc_msg_send_validation(struct smc_connection *conn,
+ struct smc_cdc_tx_pend *pend,
+ struct smc_wr_buf *wr_buf)
{
struct smc_host_cdc_msg *local = &conn->local_tx_ctrl;
struct smc_link *link = conn->lnk;
- struct smc_cdc_tx_pend *pend;
- struct smc_wr_buf *wr_buf;
struct smc_cdc_msg *peer;
int rc;
- rc = smc_cdc_get_free_slot(conn, link, &wr_buf, NULL, &pend);
- if (rc)
- return rc;
-
peer = (struct smc_cdc_msg *)wr_buf;
peer->common.type = local->common.type;
peer->len = local->len;