summaryrefslogtreecommitdiffstats
path: root/net/vmw_vsock
diff options
context:
space:
mode:
authorWillem de Bruijn <willemb@google.com>2017-09-26 12:19:37 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-10-21 17:09:03 +0200
commit1b6c80e797eeadf643861f8340ed5791d813d80c (patch)
tree3c0a328591851091da7c4da352836648b61e8989 /net/vmw_vsock
parentee534927f0c0922ec8ad0192af8dcb6e9cbea8d1 (diff)
downloadlinux-stable-1b6c80e797eeadf643861f8340ed5791d813d80c.tar.gz
linux-stable-1b6c80e797eeadf643861f8340ed5791d813d80c.tar.bz2
linux-stable-1b6c80e797eeadf643861f8340ed5791d813d80c.zip
packet: in packet_do_bind, test fanout with bind_lock held
[ Upstream commit 4971613c1639d8e5f102c4e797c3bf8f83a5a69e ] Once a socket has po->fanout set, it remains a member of the group until it is destroyed. The prot_hook must be constant and identical across sockets in the group. If fanout_add races with packet_do_bind between the test of po->fanout and taking the lock, the bind call may make type or dev inconsistent with that of the fanout group. Hold po->bind_lock when testing po->fanout to avoid this race. I had to introduce artificial delay (local_bh_enable) to actually observe the race. Fixes: dc99f600698d ("packet: Add fanout support.") Signed-off-by: Willem de Bruijn <willemb@google.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/vmw_vsock')
0 files changed, 0 insertions, 0 deletions