diff options
| author | Takashi Iwai <tiwai@suse.de> | 2017-03-21 13:56:04 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-03-30 09:35:15 +0200 |
| commit | b55ffcb1bc8a9c40db928f568ef61016ac681c29 (patch) | |
| tree | 1c86d13c6b5075d2d1dcbbeff2ee1da5c13fd5aa /sound/pci/ctxfi | |
| parent | 549993001e7de0553d85c9022dc41d5b3ff7d1ff (diff) | |
| download | linux-stable-b55ffcb1bc8a9c40db928f568ef61016ac681c29.tar.gz linux-stable-b55ffcb1bc8a9c40db928f568ef61016ac681c29.tar.bz2 linux-stable-b55ffcb1bc8a9c40db928f568ef61016ac681c29.zip | |
ALSA: seq: Fix racy cell insertions during snd_seq_pool_done()
commit c520ff3d03f0b5db7146d9beed6373ad5d2a5e0e upstream.
When snd_seq_pool_done() is called, it marks the closing flag to
refuse the further cell insertions. But snd_seq_pool_done() itself
doesn't clear the cells but just waits until all cells are cleared by
the caller side. That is, it's racy, and this leads to the endless
stall as syzkaller spotted.
This patch addresses the racy by splitting the setup of pool->closing
flag out of snd_seq_pool_done(), and calling it properly before
snd_seq_pool_done().
BugLink: http://lkml.kernel.org/r/CACT4Y+aqqy8bZA1fFieifNxR2fAfFQQABcBHj801+u5ePV0URw@mail.gmail.com
Reported-and-tested-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound/pci/ctxfi')
0 files changed, 0 insertions, 0 deletions