From 669a064625fa3a06ddf8a4ac1f35b7436b99f133 Mon Sep 17 00:00:00 2001 From: Lukas Bulwahn Date: Thu, 23 Dec 2021 13:53:00 +0100 Subject: block: drop needless assignment in set_task_ioprio() Commit 5fc11eebb4a9 ("block: open code create_task_io_context in set_task_ioprio") introduces a needless assignment 'ioc = task->io_context', as the local variable ioc is not further used before returning. Even after the further fix, commit a957b61254a7 ("block: fix error in handling dead task for ioprio setting"), the assignment still remains needless. Drop this needless assignment in set_task_ioprio(). This code smell was identified with 'make clang-analyzer'. Fixes: 5fc11eebb4a9 ("block: open code create_task_io_context in set_task_ioprio") Signed-off-by: Lukas Bulwahn Reviewed-by: Christoph Hellwig Link: https://lore.kernel.org/r/20211223125300.20691-1-lukas.bulwahn@gmail.com Signed-off-by: Jens Axboe --- block/blk-ioc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'block') diff --git a/block/blk-ioc.c b/block/blk-ioc.c index 71c3a933cf16..11f49f78db32 100644 --- a/block/blk-ioc.c +++ b/block/blk-ioc.c @@ -284,12 +284,10 @@ int set_task_ioprio(struct task_struct *task, int ioprio) kmem_cache_free(iocontext_cachep, ioc); goto out; } - if (task->io_context) { + if (task->io_context) kmem_cache_free(iocontext_cachep, ioc); - ioc = task->io_context; - } else { + else task->io_context = ioc; - } } task->io_context->ioprio = ioprio; out: -- cgit v1.2.3