From b5e47729043c9224b21ab3dc7c63e8a38dbb4923 Mon Sep 17 00:00:00 2001 From: Stefan Richter Date: Tue, 27 Jul 2010 10:28:30 +0200 Subject: firewire: nosy: misc cleanups Extend copyright note to 2007, c.f. Kristian's git log. Includes: - replace some by - add required indirectly included - order alphabetically Coding style related changes: - change to utf8 - normalize whitespace - normalize comment style - remove usages of __FUNCTION__ - remove an unnecessary cast from void * Const and static declarations: - driver_name is not const in pci_driver.name, drop const qualifier - driver_name can be taken from KBUILD_MODNAME - the global variable minors[] can and should be static - constify struct file_operations instance Data types: - Remove unused struct member struct packet.code. struct packet is only used for driver-internal bookkeeping; it does not appear on the wire or in DMA programs or the userspace ABI. Hence the unused member .code can be removed without worries. Preprocessor macros: - unroll a preprocessor macro that containd a return - use list_for_each_entry Printk: - add missing terminating \n in some format strings Signed-off-by: Stefan Richter --- drivers/firewire/nosy-user.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'drivers/firewire/nosy-user.h') diff --git a/drivers/firewire/nosy-user.h b/drivers/firewire/nosy-user.h index c9a1682ab45e..ebef97f4ecf9 100644 --- a/drivers/firewire/nosy-user.h +++ b/drivers/firewire/nosy-user.h @@ -1,8 +1,8 @@ #ifndef __nosy_user_h #define __nosy_user_h -#include -#include +#include +#include #define NOSY_IOC_GET_STATS _IOR('&', 0, struct nosy_stats) #define NOSY_IOC_START _IO('&', 1) @@ -10,11 +10,11 @@ #define NOSY_IOC_FILTER _IOW('&', 2, __u32) struct nosy_stats { - __u32 total_packet_count; - __u32 lost_packet_count; + __u32 total_packet_count; + __u32 lost_packet_count; }; -/* +/* * Format of packets returned from the kernel driver: * * quadlet with timestamp (microseconds) -- cgit v1.2.3