From 615cba3557f1bad6061acde2067a3edbf80d90c2 Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Sat, 23 Feb 2019 20:42:19 +0100 Subject: staging: speakup: Note that simple_strtoul can't simply be replaced by kstrtoul We often receive patches which erroneously try to use kstrtoul in these places. Signed-off-by: Samuel Thibault Signed-off-by: Greg Kroah-Hartman --- drivers/staging/speakup/varhandlers.c | 1 + 1 file changed, 1 insertion(+) (limited to 'drivers/staging/speakup/varhandlers.c') diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c index 1b545152cc49..3c944cb8f547 100644 --- a/drivers/staging/speakup/varhandlers.c +++ b/drivers/staging/speakup/varhandlers.c @@ -328,6 +328,7 @@ char *spk_s2uchar(char *start, char *dest) { int val; + /* Do not replace with kstrtoul: here we need start to be updated */ val = simple_strtoul(skip_spaces(start), &start, 10); if (*start == ',') start++; -- cgit v1.2.3