From dfd375864ac1e2ee60ed2d61820697ac01642f80 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Mon, 30 Nov 2020 23:04:12 -0800 Subject: 9p: Uninitialized variable in v9fs_writeback_fid() If v9fs_fid_lookup_with_uid() fails then "fid" is not initialized. The v9fs_fid_lookup_with_uid() can't return NULL. If it returns an error pointer then we can still pass that to clone_fid() and it will return the error pointer back again. Fixes: 6636b6dcc3db ("9p: add refcount to p9_fid struct") Signed-off-by: Dan Carpenter Signed-off-by: Dominique Martinet --- fs/9p/fid.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'fs/9p') diff --git a/fs/9p/fid.c b/fs/9p/fid.c index 50118ec72a92..79837f1b1c91 100644 --- a/fs/9p/fid.c +++ b/fs/9p/fid.c @@ -302,8 +302,7 @@ struct p9_fid *v9fs_writeback_fid(struct dentry *dentry) struct p9_fid *fid, *ofid; ofid = v9fs_fid_lookup_with_uid(dentry, GLOBAL_ROOT_UID, 0); - if (ofid && !IS_ERR(ofid)) - fid = clone_fid(ofid); + fid = clone_fid(ofid); if (IS_ERR(fid)) goto error_out; p9_client_clunk(ofid); -- cgit v1.2.3