diff options
| author | Andi Kleen <ak@suse.de> | 2007-09-06 16:59:52 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-09-10 18:57:47 -0700 |
| commit | a534b679180025aa324ebd63c05516e478551cfd (patch) | |
| tree | f89dc89909bcd9f67dc10da44314e75753785df8 | |
| parent | 23d5ea5d3edcfe899cd91fca87a4af799bcc5794 (diff) | |
| download | linux-a534b679180025aa324ebd63c05516e478551cfd.tar.gz linux-a534b679180025aa324ebd63c05516e478551cfd.tar.bz2 linux-a534b679180025aa324ebd63c05516e478551cfd.zip | |
x86_64: Remove CLFLUSH in text_poke()
The CLFLUSH for the modified code line in text_poke was supposed
to speed up CPU recovery. Unfortunately it seems to cause hangs
on some VIA C3s (at least on VIA Esther Model 10 Stepping 9)
Remove it.
Thanks to Stefan Becker for reporting/testing.
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | arch/i386/kernel/alternative.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/arch/i386/kernel/alternative.c b/arch/i386/kernel/alternative.c index 9f4ac8b02de4..bd72d94e713e 100644 --- a/arch/i386/kernel/alternative.c +++ b/arch/i386/kernel/alternative.c @@ -445,8 +445,6 @@ void __kprobes text_poke(void *addr, unsigned char *opcode, int len) { memcpy(addr, opcode, len); sync_core(); - /* Not strictly needed, but can speed CPU recovery up. Ignore cross cacheline - case. */ - if (cpu_has_clflush) - asm("clflush (%0) " :: "r" (addr) : "memory"); + /* Could also do a CLFLUSH here to speed up CPU recovery; but + that causes hangs on some VIA CPUs. */ } |