summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBen Hutchings <bhutchings@solarflare.com>2010-12-07 18:29:52 +0000
committerBen Hutchings <bhutchings@solarflare.com>2010-12-07 18:31:48 +0000
commitac33ac610dc613b2b1c938f8b61eef651ab72563 (patch)
treeff476efa60a15e9dd929fe24e6bcc032ac40d934
parentcd38557d78554fd4318fe448f728a8d7ff1cbabb (diff)
downloadlinux-ac33ac610dc613b2b1c938f8b61eef651ab72563.tar.gz
linux-ac33ac610dc613b2b1c938f8b61eef651ab72563.tar.bz2
linux-ac33ac610dc613b2b1c938f8b61eef651ab72563.zip
sfc: Log start and end of ethtool self-test at INFO level
Add message at start of self-test and increase log level of message at end of self-test, so that any other messages produced during the test are clearly associated with it. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
-rw-r--r--drivers/net/sfc/ethtool.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/net/sfc/ethtool.c b/drivers/net/sfc/ethtool.c
index aae756bf47ee..d51a6b1f4766 100644
--- a/drivers/net/sfc/ethtool.c
+++ b/drivers/net/sfc/ethtool.c
@@ -582,6 +582,9 @@ static void efx_ethtool_self_test(struct net_device *net_dev,
goto fail1;
}
+ netif_info(efx, drv, efx->net_dev, "starting %sline testing\n",
+ (test->flags & ETH_TEST_FL_OFFLINE) ? "off" : "on");
+
/* We need rx buffers and interrupts. */
already_up = (efx->net_dev->flags & IFF_UP);
if (!already_up) {
@@ -600,9 +603,9 @@ static void efx_ethtool_self_test(struct net_device *net_dev,
if (!already_up)
dev_close(efx->net_dev);
- netif_dbg(efx, drv, efx->net_dev, "%s %sline self-tests\n",
- rc == 0 ? "passed" : "failed",
- (test->flags & ETH_TEST_FL_OFFLINE) ? "off" : "on");
+ netif_info(efx, drv, efx->net_dev, "%s %sline self-tests\n",
+ rc == 0 ? "passed" : "failed",
+ (test->flags & ETH_TEST_FL_OFFLINE) ? "off" : "on");
fail2:
fail1: