summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteffen Klassert <steffen.klassert@secunet.com>2014-09-22 10:07:26 +0200
committerDavid S. Miller <davem@davemloft.net>2014-09-28 16:19:46 -0400
commitcd0a0bd9b8e157b19aa38eeac30c60f1a0d010bd (patch)
treebc590a02ea4c79082993e0d026d9a6d60b894345
parentd814b847be7b47575a1cc2194760d3461e1c43c8 (diff)
downloadlinux-cd0a0bd9b8e157b19aa38eeac30c60f1a0d010bd.tar.gz
linux-cd0a0bd9b8e157b19aa38eeac30c60f1a0d010bd.tar.bz2
linux-cd0a0bd9b8e157b19aa38eeac30c60f1a0d010bd.zip
ip6_gre: Return an error when adding an existing tunnel.
ip6gre_tunnel_locate() should not return an existing tunnel if create is true. Otherwise it is possible to add the same tunnel multiple times without getting an error. So return NULL if the tunnel that should be created already exists. Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv6/ip6_gre.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c
index d172ec4ec9d3..f304471477dc 100644
--- a/net/ipv6/ip6_gre.c
+++ b/net/ipv6/ip6_gre.c
@@ -314,6 +314,8 @@ static struct ip6_tnl *ip6gre_tunnel_locate(struct net *net,
struct ip6gre_net *ign = net_generic(net, ip6gre_net_id);
t = ip6gre_tunnel_find(net, parms, ARPHRD_IP6GRE);
+ if (t && create)
+ return NULL;
if (t || !create)
return t;