diff options
| author | Rusty Russell <rusty@rustcorp.com.au> | 2010-08-11 23:04:40 -0600 |
|---|---|---|
| committer | Rusty Russell <rusty@rustcorp.com.au> | 2010-08-11 23:04:41 +0930 |
| commit | a6de51b2787012ba3ab62c7d50df1b749b83d5f0 (patch) | |
| tree | e3053c23297b57bb85b5abcabfd49635511ec140 | |
| parent | 4ef2db016aab27af05a95aeab1c30ad3f2fed7b9 (diff) | |
| download | linux-a6de51b2787012ba3ab62c7d50df1b749b83d5f0.tar.gz linux-a6de51b2787012ba3ab62c7d50df1b749b83d5f0.tar.bz2 linux-a6de51b2787012ba3ab62c7d50df1b749b83d5f0.zip | |
param: don't deref arg in __same_type() checks
gcc allows this when arg is a function, but sparse complains:
drivers/char/ipmi/ipmi_watchdog.c:303:1: error: cannot dereference this type
drivers/char/ipmi/ipmi_watchdog.c:307:1: error: cannot dereference this type
drivers/char/ipmi/ipmi_watchdog.c:311:1: error: cannot dereference this type
Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Tested-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
| -rw-r--r-- | include/linux/moduleparam.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h index 893549c04265..9d2f1837b3d8 100644 --- a/include/linux/moduleparam.h +++ b/include/linux/moduleparam.h @@ -125,7 +125,7 @@ struct kparam_array */ #define module_param_cb(name, ops, arg, perm) \ __module_param_call(MODULE_PARAM_PREFIX, \ - name, ops, arg, __same_type(*(arg), bool), perm) + name, ops, arg, __same_type((arg), bool *), perm) /* On alpha, ia64 and ppc64 relocations to global data cannot go into read-only sections (which is part of respective UNIX ABI on these @@ -157,7 +157,7 @@ struct kparam_array { (void *)set, (void *)get }; \ __module_param_call(MODULE_PARAM_PREFIX, \ name, &__param_ops_##name, arg, \ - __same_type(*(arg), bool), \ + __same_type(arg, bool *), \ (perm) + sizeof(__check_old_set_param(set))*0) /* We don't get oldget: it's often a new-style param_get_uint, etc. */ @@ -330,9 +330,9 @@ extern int param_get_bool(char *buffer, const struct kernel_param *kp); #define param_check_bool(name, p) \ static inline void __check_##name(void) \ { \ - BUILD_BUG_ON(!__same_type(*(p), bool) && \ - !__same_type(*(p), unsigned int) && \ - !__same_type(*(p), int)); \ + BUILD_BUG_ON(!__same_type((p), bool *) && \ + !__same_type((p), unsigned int *) && \ + !__same_type((p), int *)); \ } extern struct kernel_param_ops param_ops_invbool; |