diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-08-19 09:03:00 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2012-08-20 20:44:36 +0100 |
| commit | bc72d26bdb23c908ad52ec2d321a137d27762f08 (patch) | |
| tree | e30417c873c7a53b5bce0e6949956b1400486dcd | |
| parent | b18e93a493626c1446f9788ebd5844d008bbf71c (diff) | |
| download | linux-bc72d26bdb23c908ad52ec2d321a137d27762f08.tar.gz linux-bc72d26bdb23c908ad52ec2d321a137d27762f08.tar.bz2 linux-bc72d26bdb23c908ad52ec2d321a137d27762f08.zip | |
ASoC: am3517evm: fix error return code
It was forgotten to initialize ret to the result of calling
snd_soc_dai_set_sysclk, unlike at the other calls in the same function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
| -rw-r--r-- | sound/soc/omap/am3517evm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/omap/am3517evm.c b/sound/soc/omap/am3517evm.c index 009533ab8d18..df65f98211ec 100644 --- a/sound/soc/omap/am3517evm.c +++ b/sound/soc/omap/am3517evm.c @@ -59,7 +59,7 @@ static int am3517evm_hw_params(struct snd_pcm_substream *substream, return ret; } - snd_soc_dai_set_sysclk(cpu_dai, OMAP_MCBSP_FSR_SRC_FSX, 0, + ret = snd_soc_dai_set_sysclk(cpu_dai, OMAP_MCBSP_FSR_SRC_FSX, 0, SND_SOC_CLOCK_IN); if (ret < 0) { printk(KERN_ERR "can't set CPU system clock OMAP_MCBSP_FSR_SRC_FSX\n"); |