diff options
| author | Heiko Stübner <heiko@sntech.de> | 2012-02-01 09:12:23 -0800 |
|---|---|---|
| committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2012-02-01 09:12:54 -0800 |
| commit | 42f578741bc59dc871bef03ff0f72dd197388409 (patch) | |
| tree | 23383d1b35459bfd26bfd3d8815b80255ed36fc9 | |
| parent | 52965cc012f7a3cf35f06485ec275ebf3b3fddae (diff) | |
| download | linux-42f578741bc59dc871bef03ff0f72dd197388409.tar.gz linux-42f578741bc59dc871bef03ff0f72dd197388409.tar.bz2 linux-42f578741bc59dc871bef03ff0f72dd197388409.zip | |
Input: evdev - fix variable initialisation
Commit 509f87c5f564 (evdev - do not block waiting for an event if fd
is nonblock) created a code path were it was possible to use retval
uninitialized.
This could lead to the xorg evdev input driver getting corrupt data
and refusing to work with log messages like
AUO-Pixcir touchscreen: Read error: Success
sg060_keys: Read error: Success
AUO-Pixcir touchscreen: Read error: Success
sg060_keys: Read error: Success
(for drivers auo-pixcir-ts and gpio-keys).
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Dima Zavin <dima@android.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
| -rw-r--r-- | drivers/input/evdev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c index 76457d50bc34..afc166fcc3d9 100644 --- a/drivers/input/evdev.c +++ b/drivers/input/evdev.c @@ -386,7 +386,7 @@ static ssize_t evdev_read(struct file *file, char __user *buffer, struct evdev_client *client = file->private_data; struct evdev *evdev = client->evdev; struct input_event event; - int retval; + int retval = 0; if (count < input_event_size()) return -EINVAL; |