diff options
| author | Sekhar Nori <nsekhar@ti.com> | 2014-07-14 18:43:46 +0530 |
|---|---|---|
| committer | Tony Lindgren <tony@atomide.com> | 2014-07-14 09:24:43 -0700 |
| commit | ba394f0b6aa7a4a6afe67176da5d29f0ac59c48d (patch) | |
| tree | c56b117a9136ad1b302a54fd8b2f08d9b166669d | |
| parent | 1d29a0722f6c38f79785c9ffb911730598de84e2 (diff) | |
| download | linux-ba394f0b6aa7a4a6afe67176da5d29f0ac59c48d.tar.gz linux-ba394f0b6aa7a4a6afe67176da5d29f0ac59c48d.tar.bz2 linux-ba394f0b6aa7a4a6afe67176da5d29f0ac59c48d.zip | |
ARM: OMAP2+: l2c: squelch warning dump on power control setting
On OMAP SOCs using PL310 controllers, power_ctrl register is not
accessible from non-secure software even on PL310 versions which
support it. The secure code takes care of setting it up correctly
and power transitions are proven on these devices.
For example, AM437x has L2C-310 version r3p3 and ROM code on that
device does not support writing to L2C-310 power control register.
The L2C driver, however, tries writing to this register for all
revisions >= r3p0.
This leads to a warning dump on boot which leads most users to believe
that L2 cache is non-functional.
Since the problem is understood, and cannot be addressed through
software, replace the warning with a pr_info() while maintaining the
WARN_ON() for other truly unexpected scenarios.
Reported-by: Nishanth Menon <nm@ti.com>
Tested-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
| -rw-r--r-- | arch/arm/mach-omap2/omap4-common.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c index 539e8106eb96..a0fe747634c1 100644 --- a/arch/arm/mach-omap2/omap4-common.c +++ b/arch/arm/mach-omap2/omap4-common.c @@ -168,6 +168,10 @@ static void omap4_l2c310_write_sec(unsigned long val, unsigned reg) smc_op = OMAP4_MON_L2X0_PREFETCH_INDEX; break; + case L310_POWER_CTRL: + pr_info_once("OMAP L2C310: ROM does not support power control setting\n"); + return; + default: WARN_ONCE(1, "OMAP L2C310: ignoring write to reg 0x%x\n", reg); return; |