summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDave Chinner <dchinner@redhat.com>2012-06-12 14:20:26 +1000
committerBen Myers <bpm@sgi.com>2012-06-21 14:20:20 -0500
commit76d095388b040229ea1aad7dea45be0cfa20f589 (patch)
treee3aa3051f396898675fff5ae227fd7c7d0f46aa6
parent9a3a5dab63461b84213052888bf38a962b22d035 (diff)
downloadlinux-76d095388b040229ea1aad7dea45be0cfa20f589.tar.gz
linux-76d095388b040229ea1aad7dea45be0cfa20f589.tar.bz2
linux-76d095388b040229ea1aad7dea45be0cfa20f589.zip
xfs: fix allocbt cursor leak in xfs_alloc_ag_vextent_near
When we fail to find an matching extent near the requested extent specification during a left-right distance search in xfs_alloc_ag_vextent_near, we fail to free the original cursor that we used to look up the XFS_BTNUM_CNT tree and hence leak it. Reported-by: Chris J Arges <chris.j.arges@canonical.com> Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Ben Myers <bpm@sgi.com>
-rw-r--r--fs/xfs/xfs_alloc.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/xfs/xfs_alloc.c b/fs/xfs/xfs_alloc.c
index a996e398692b..9d1aeb7e2734 100644
--- a/fs/xfs/xfs_alloc.c
+++ b/fs/xfs/xfs_alloc.c
@@ -1080,6 +1080,7 @@ restart:
goto restart;
}
+ xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR);
trace_xfs_alloc_size_neither(args);
args->agbno = NULLAGBLOCK;
return 0;