diff options
| author | Cyril Roelandt <tipecaml@gmail.com> | 2012-11-22 23:20:31 +0100 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2012-11-22 23:20:31 +0100 |
| commit | 05bce79e6d24ee6eb2beddf0f6314358404d472f (patch) | |
| tree | b7eb9e5e6dc1f3585493b07218681ba76b510182 | |
| parent | 66fd3835ac9a3740a7bf953b439e54dbc326d272 (diff) | |
| download | linux-05bce79e6d24ee6eb2beddf0f6314358404d472f.tar.gz linux-05bce79e6d24ee6eb2beddf0f6314358404d472f.tar.bz2 linux-05bce79e6d24ee6eb2beddf0f6314358404d472f.zip | |
ACPI: drop unnecessary local variable from acpi_system_write_wakeup_device()
The LEN variable is unsigned, therefore checking whether it is less than 0 is
useless. Also drop the LEN variable, since the COUNT parameter can be used
instead.
[rjw: Changed the subject.]
Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
| -rw-r--r-- | drivers/acpi/proc.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/drivers/acpi/proc.c b/drivers/acpi/proc.c index 27adb090bb30..ef98796b3824 100644 --- a/drivers/acpi/proc.c +++ b/drivers/acpi/proc.c @@ -362,16 +362,13 @@ acpi_system_write_wakeup_device(struct file *file, struct list_head *node, *next; char strbuf[5]; char str[5] = ""; - unsigned int len = count; - if (len > 4) - len = 4; - if (len < 0) - return -EFAULT; + if (count > 4) + count = 4; - if (copy_from_user(strbuf, buffer, len)) + if (copy_from_user(strbuf, buffer, count)) return -EFAULT; - strbuf[len] = '\0'; + strbuf[count] = '\0'; sscanf(strbuf, "%s", str); mutex_lock(&acpi_device_lock); |