summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndy Grover <agrover@redhat.com>2015-03-31 15:04:37 -0700
committerNicholas Bellinger <nab@linux-iscsi.org>2015-04-01 21:42:51 -0700
commit86d65dc4fe74d5b3228fe13c5eff0b10ae6808eb (patch)
tree383ed332796de3fa1b6c5cc9fbec0a497e7e2fff
parent9bc6548f372d8c829235095d91de99d8df79db6e (diff)
downloadlinux-86d65dc4fe74d5b3228fe13c5eff0b10ae6808eb.tar.gz
linux-86d65dc4fe74d5b3228fe13c5eff0b10ae6808eb.tar.bz2
linux-86d65dc4fe74d5b3228fe13c5eff0b10ae6808eb.zip
target: Allow userspace to write 1 to attrib/emulate_fua_write
Before 4.0, reading attrib/emulate_fua_write has returned 1. Saved configs created on a pre-4.0 kernel will try to write that back when restoring LIO configuration. This should succeed with no effect, and issue a warning. See https://bugzilla.redhat.com/show_bug.cgi?id=1206184 Reported-by: Yanko Kaneti <yaneti@declera.com> Reported-by: Juan Quintela <quintela@redhat.com> Signed-off-by: Andy Grover <agrover@redhat.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
-rw-r--r--drivers/target/target_core_device.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 79b4ec3ca2db..7faa6aef9a4d 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -781,8 +781,8 @@ int se_dev_set_emulate_fua_write(struct se_device *dev, int flag)
}
if (flag &&
dev->transport->get_write_cache) {
- pr_err("emulate_fua_write not supported for this device\n");
- return -EINVAL;
+ pr_warn("emulate_fua_write not supported for this device, ignoring\n");
+ return 0;
}
if (dev->export_count) {
pr_err("emulate_fua_write cannot be changed with active"