diff options
| author | Tejun Heo <htejun@gmail.com> | 2006-11-17 12:05:11 +0900 |
|---|---|---|
| committer | Tejun Heo <htejun@gmail.com> | 2006-12-03 17:56:23 +0900 |
| commit | 582982e6991d6718ddadf8751072b50a850dde48 (patch) | |
| tree | d9d84c51cd3e6939a114f079e7fc5180d688eca2 | |
| parent | 2eab80ac0c96fb98267afeb12a4899801564c75b (diff) | |
| download | linux-582982e6991d6718ddadf8751072b50a850dde48.tar.gz linux-582982e6991d6718ddadf8751072b50a850dde48.tar.bz2 linux-582982e6991d6718ddadf8751072b50a850dde48.zip | |
[PATCH] libata: remove unused HSM_ST_UNKNOWN
HSM_ST_UNKNOWN is not used anywhere. Its value is zero and supposed
to serve sanity check purpose but HSM_ST_IDLE is used for that
purpose. This unused state causes confusion. After a port is
initialized but before the first command is executed, the idle hsm
state is UNKNOWN. However, once a command has completed, the idle hsm
state is IDLE. This defeats sanity check in ata_pio_task() for the
first command.
This patch removes HSM_ST_UNKNOWN and consequently make HSM_ST_IDLE
the default state.
Signed-off-by: Tejun Heo <htejun@gmail.com>
| -rw-r--r-- | include/linux/libata.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/linux/libata.h b/include/linux/libata.h index 9080789913f7..6013211ac7de 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -318,7 +318,6 @@ enum { }; enum hsm_task_states { - HSM_ST_UNKNOWN, /* state unknown */ HSM_ST_IDLE, /* no command on going */ HSM_ST, /* (waiting the device to) transfer data */ HSM_ST_LAST, /* (waiting the device to) complete command */ |